Fixed flipping of the nested rules and supports queries #21
Conversation
| @@ -3,7 +3,7 @@ import { compile, middleware, prefixer, serialize, stringify } from 'stylis'; | |||
| import stylisRtlPlugin from './stylis-rtl'; | |||
|
|
|||
| const stylis = (css, extraPlugins = []) => | |||
| serialize(compile(css), middleware([stylisRtlPlugin, ...extraPlugins, stringify])); | |||
| serialize(compile(css), middleware([...extraPlugins, stylisRtlPlugin, stringify])); | |||
There was a problem hiding this comment.
requiring this order for the prefixer plugin is unfortunate - but this order makes IMHO more sense (for the prefixer within extraPlugins), let's just do prefixing first which can insert new nodes (sort of) and then do the flipping
You could try to handle this for the other order as well, but I personally have no energy for it so this is what I'm proposing. It can be seen as a breaking change though - so u need to decide how to best handle this.
|
Hi @Andarist ,I also encountered the same problem as issue emotion-js/emotion#2156. May I know when this pr can be merged? |
|
@chenbolan im not a maintainer of this package. Im sure that whenever @probablyup has a chance to look at it he will. OSS is a volunteer work - for the time being you can use my fork. |
|
The PR fixes #22 too. |
|
@oliviertassinari could you check if the newly added tests cover the #22 situation - or should some tests be added here to avoid possible regressions? |
|
The exisiting test seems good enough. |
|
Any ideas when this PR will be released under a new version? |
fixes emotion-js/emotion#2156