Added TODO to remove isAggregate eventually.

substrait-io · Oct 1, 2024 · ce112d7 · ce112d7
1 parent bd114dc
commit ce112d7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/src/substrait/textplan/PlanPrinterVisitor.cpp b/src/substrait/textplan/PlanPrinterVisitor.cpp
@@ -72,6 +72,7 @@ std::string visitEnumArgument(const std::string& str) {
 }
 
 bool isAggregate(const SymbolInfo* symbol) {
+  // TODO: Remove after the relation type is one type internally.
   if (const auto typeCase =
           ANY_CAST_IF(::substrait::proto::Rel::RelTypeCase, symbol->subtype)) {
     return (typeCase == ::substrait::proto::Rel::kAggregate);

diff --git a/src/substrait/textplan/parser/SubstraitPlanRelationVisitor.cpp b/src/substrait/textplan/parser/SubstraitPlanRelationVisitor.cpp
@@ -317,6 +317,7 @@ bool isRelationEmitDetail(SubstraitPlanParser::Relation_detailContext* ctx) {
 }
 
 bool isAggregate(const SymbolInfo* symbol) {
+  // TODO: Remove once relation types have a unified type internally.
   if (const auto typeCase = ANY_CAST_IF(RelationType, symbol->subtype)) {
     return (typeCase == RelationType::kAggregate);
   }

diff --git a/src/substrait/textplan/parser/SubstraitPlanSubqueryRelationVisitor.cpp b/src/substrait/textplan/parser/SubstraitPlanSubqueryRelationVisitor.cpp
@@ -373,6 +373,7 @@ comparisonToProto(const std::string& text) {
 }
 
 bool isAggregate(const SymbolInfo* symbol) {
+  // TODO: Remove after the relation type is one type internally.
   if (const auto typeCase = ANY_CAST_IF(RelationType, symbol->subtype)) {
     return (typeCase == RelationType::kAggregate);
   }