-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct cmake library interdependencies #100
fix: correct cmake library interdependencies #100
Conversation
Awesome -- thank you for the quick fix! Probably a much better fix than what I had in mind :) For completeness, here are the dependency graphs before and after this PR. Before the change, we can see several inter-dependent targets; after the change, it's a nice DAG. Before: After: I generated them running set(GRAPHVIZ_IGNORE_TARGETS "absl_*;gmock*;gtest*;protobuf*;yaml-cpp*;fmt*;-lrt;Threads*;/usr/*;.*_test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve if CI passes. I won't pretend to have fully internalized these changes but I don't see anything odd or out of place.
Thanks for finding this issue as well as providing the visualization of the dependencies. I'll probably use this trick to prevent such issues in the future. |
Sure thing! Another possibility is to (also) build with |
This eliminates the cycles described in #99.
PlanPrinterVisitor is now part of symbol_table.
BasePlanProtoVisitor (which PlanPrinterVisitor depends on) is now its own library.