Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faster whisper implementation #177

Merged
merged 26 commits into from
Sep 5, 2024
Merged

faster whisper implementation #177

merged 26 commits into from
Sep 5, 2024

Conversation

samos123
Copy link
Contributor

@samos123 samos123 commented Sep 4, 2024

The issue with faster whisper is that it does strong validation on the model name. It has to match one of their predefined models. This won't work for KubeAI. So as a workaround, I've removed the model field from the request body before sending it to the backend.

@samos123 samos123 force-pushed the whisper branch 2 times, most recently from 3fbf971 to 501841e Compare September 4, 2024 01:00
@samos123 samos123 changed the title wip faster whisper implementation faster whisper implementation Sep 4, 2024
Copy link
Contributor

@nstogner nstogner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested an optimization change - if this works as-is feel free to merge and submit an Issue to address the optimization post-merge.

internal/modelproxy/request.go Outdated Show resolved Hide resolved
@samos123 samos123 merged commit 604966d into main Sep 5, 2024
5 checks passed
@samos123 samos123 deleted the whisper branch September 5, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants