Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP X-Label-Selector headers to support Multitenancy #282

Merged
merged 13 commits into from
Oct 24, 2024

Conversation

nstogner
Copy link
Contributor

@nstogner nstogner commented Oct 21, 2024

Add the ability to filter Models by label selector when sending HTTP requests to the OpenAI compatible API endpoints.

@nstogner nstogner changed the title Authorization for Model inference Label Selector HTTP Headers Oct 23, 2024
@nstogner nstogner changed the title Label Selector HTTP Headers Label Selector HTTP Headers to support Multitenancy Oct 23, 2024
@nstogner nstogner changed the title Label Selector HTTP Headers to support Multitenancy Add support for HTTP X-Label-Selector headers to support Multitenancy Oct 23, 2024
Copy link
Contributor

@samos123 samos123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits, but looks good otherwise.

docs/how-to/architect-for-multitenancy.md Show resolved Hide resolved
docs/how-to/architect-for-multitenancy.md Outdated Show resolved Hide resolved
internal/modelscaler/scaler.go Outdated Show resolved Hide resolved
@@ -0,0 +1,63 @@
# Multitenancy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this doc? It's confusing to keep it imo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I have seen in the past is that proposals are not generally removed even after implementation. It can be nice to understand why a particular path was not pursued.

Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good!
I added some minor nits only. Feel free to ignore them

internal/modelproxy/handler.go Outdated Show resolved Hide resolved
test/integration/utils_test.go Show resolved Hide resolved
test/integration/selector_test.go Outdated Show resolved Hide resolved
test/integration/selector_test.go Outdated Show resolved Hide resolved
test/integration/selector_test.go Show resolved Hide resolved
internal/modelproxy/handler_test.go Outdated Show resolved Hide resolved
internal/modelproxy/handler_test.go Outdated Show resolved Hide resolved
test/integration/utils_test.go Show resolved Hide resolved
test/integration/utils_test.go Show resolved Hide resolved
internal/modelproxy/request.go Outdated Show resolved Hide resolved
@nstogner nstogner merged commit 4213d3a into main Oct 24, 2024
11 checks passed
@nstogner nstogner deleted the auth branch October 24, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants