This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… would require adding gadget
ratankaliani
commented
Sep 6, 2023
@@ -982,4 +911,331 @@ pub(crate) mod tests { | |||
|
|||
println!("Verified proof"); | |||
} | |||
|
|||
// TODO: Add these tests back once the interface for using Curta's SHA gadget is straightforward. Currently, we'd need to compute the total number of SHA's done in each of these tests, and fill out the rest of the SHA's similar to how it's done in test_skip & test_step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating these tests to use the Curta gadget felt unnecessary (given integration tests pass), will add them back once the Curta interface is more clean.
jtguibas
approved these changes
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
test_skip_large
andtest_step_large
pass with 128 validators.test_step_large
currently takes ~14.5 minutes to generate a proof.test_skip_large
currently takes ~15.5 minutes to generate a proof.Tried to route a wire that isn't routable
issue (separateget_total_voting_power
computation into 2 chunks, to avoid exceeding themax_num_routed_wires
in the plonky2 config)Future Optimizations
Future Cleanup
skip
andstep
https://github.com/succinctlabs/zkqgb/blob/5585abf6d067071fff00c86ff1722bd1bef2fd82/src/verify.rs#L290-L302plonky2x
for SHA256 that allocates the number of Curta gadget's necessary, this logic can be removed.validator.rs
that call SHA256 have been commented out until a simplified interface for Curta's SHA256 inplonky2x
is added https://github.com/succinctlabs/zkqgb/blob/5585abf6d067071fff00c86ff1722bd1bef2fd82/src/validator.rs#L915-L1241