This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
feat: script cleanup, ProofFromByteSlices, gadget for voting power #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ointers, otherwise they're getting dropped
ratankaliani
changed the title
ratankaliani
changed the title
jtguibas
approved these changes
Jul 27, 2023
| hashed_leaves | ||
| } | ||
|
|
||
| #[derive(Clone)] |
src/validator.rs
Outdated
| fn voting_power_greater_than_threshold( | ||
| &mut self, | ||
| accumulated_power: &I64Target, | ||
| threshold: &I64Target |
src/validator.rs
Outdated
| // Compute total_vp * 2 | ||
| let (scaled_total_vp_low, scaled_total_vp_high) = self.mul_i64_by_u32(&threshold, two_u32); | ||
|
|
||
| // Check that the accumulated voting power is greater than 2/3 of the total voting power. |
There was a problem hiding this comment.
i suggest abstracting this into another function that just compares two i64s
src/validator.rs
Outdated
| (lower_product, upper_sum) | ||
| } | ||
|
|
||
| fn voting_power_greater_than_threshold( |
There was a problem hiding this comment.
can you also pass in 2, 3 here into the function so we can control the threshold
| pass | ||
| } | ||
|
|
||
| fn check_voting_power( |
There was a problem hiding this comment.
also pass in threshold numerator / denominator here for max flexibility
jtguibas
approved these changes
Jul 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
tendermint-rsfor merkle proof genProofsFromByteSlicesVerifyComputeRootHashFixes