Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: replace tiny-keccak with sha3 #54

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+141 −129
Open

perf: replace tiny-keccak with sha3 #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d64586
perf: replace tiny-keccak with sha3
xJonathanLEI Sep 13, 2024
18495a1
chore: use commit from alloy-rs
xJonathanLEI Sep 19, 2024
e096d1a
chore: switch back to crates.io
xJonathanLEI Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 56 additions & 47 deletions Cargo.lock
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ revm-primitives = { version = "9.0.0", features = [
revm-inspectors = "0.6"

# alloy
alloy-primitives = "0.8.0"
alloy-primitives = { version = "0.8.4", features = ["sha3-keccak"] }
alloy-provider = { version = "0.3", default-features = false, features = [
"reqwest",
"reqwest-rustls-tls",
Expand Down
54 changes: 27 additions & 27 deletions bin/client-eth/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions bin/client-eth/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,4 @@ sha2 = { git = "https://github.com/sp1-patches/RustCrypto-hashes", branch = "pat
ecdsa-core = { git = "https://github.com/sp1-patches/signatures", package = "ecdsa", branch = "patch-ecdsa-v0.16.9" }
tiny-keccak = { git = "https://github.com/sp1-patches/tiny-keccak", branch = "patch-v2.0.2" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're using sha3 instead of tiny-keccak, why do we still need tiny-keccak?

bn = { package = "substrate-bn", git = "https://github.com/sp1-patches/bn", branch = "patch-v0.6.0" }
sha3 = { git = "https://github.com/sp1-patches/RustCrypto-hashes", branch = "patch-sha3-v0.10.8" }
Loading
Loading