Fix for including theme image format config #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should extend the existing tests to ensure it doesn't break in the future? |
|
What would be needed in order to get this code review moving? Mocking a file_exists check will be a bit difficult in tests right? Plus I have zero experience with Prophecy (only phpunit and mockery), so will have to have some pointers how to get started :-) |
websmurf
force-pushed
the
theme-config-fix
branch
from
fc283ff
to
1ec9d0f
Compare
SebTM
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
In the documentation here is described here:
This doesn't appear to work as described
Why?
This pull requests will add the described option and will allow an image-format.xml file per theme.