fixed issue #269: changed the colour of header bar for light mode in … #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in mobile view
nabobalis
reviewed
Aug 16, 2024
| @@ -60,6 +60,7 @@ html[data-theme="light"] { | |||
| /* A lot of these colors we have inherited from pst however, I have copied them all */ | |||
| /* in here to make it obvious which colors are in use, and to shield us from any */ | |||
| /* upstream changes. */ | |||
| /* changed the colour on surface for light mode */ | |||
There was a problem hiding this comment.
Suggested change
| /* changed the colour on surface for light mode */ |
nabobalis
reviewed
Aug 16, 2024
| @@ -75,7 +76,7 @@ html[data-theme="light"] { | |||
| --pst-color-link-hover: var(--sst-accent-color-muted); | |||
| --pst-color-link: var(--sst-accent-color-bright); | |||
| --pst-color-on-background: #fff; | |||
| --pst-color-on-surface: #222832; | |||
| --pst-color-on-surface: #a2a2a0; | |||
There was a problem hiding this comment.
This change doesnt seem to have worked for me?
There was a problem hiding this comment.
I thought the issue was about the dark colour of header in light mode..
So i changed the colour parameter to light
There was a problem hiding this comment.
The issue is the color of the mobile menu icons are black on the light theme
|
Hi..
I seriously am not able to understand the issue, i can find menu icons in
the screenshot you shared on github
Can you share me circled or pointed in screenshot
…On Sat, 17 Aug, 2024, 12:53 am Nabil Freij, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/sunpy_sphinx_theme/theme/sunpy/static/sunpy_style.css
<#271 (comment)>
:
> @@ -75,7 +76,7 @@ html[data-theme="light"] {
--pst-color-link-hover: var(--sst-accent-color-muted);
--pst-color-link: var(--sst-accent-color-bright);
--pst-color-on-background: #fff;
- --pst-color-on-surface: #222832;
+ --pst-color-on-surface: #a2a2a0;
The issue is the color of the mobile menu icons are black on the light
theme
—
Reply to this email directly, view it on GitHub
<#271 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOIAEDFFR2H4TYACOX34RMDZRZGU3AVCNFSM6AAAAABMUPELLGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENBTGQYDSMRVHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
|
|
Thanks for the PR @Anuragreat but since it didn't work and there has not been any changes since, I will close this. If you want to pick it up again, just reopen this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
fixed issue #269: changed the colour of header bar for light mode in mobile view