Add tests for logging #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 94.41% 95.29% +0.88%
==========================================
Files 5 5
Lines 340 425 +85
==========================================
+ Hits 321 405 +84
- Misses 19 20 +1
Continue to review full report at Codecov.
|
haxoza
reviewed
Mar 20, 2019
|
|
||
| Remember that if you want to use assertions e.g. from ``MessagesAssertionsMixin`` | ||
| you must also add ``middleware_classes`` required by messages to your test case. | ||
| We do not add them for you in mixin, because we believe those mixin classes shouldn't | ||
| implicitly mess with middleware, because it would make it harder to understand | ||
| what and why exactly is happening in your tests. | ||
|
|
||
| You should also note that when using ``LoggingAssertionsMixing`` you need to | ||
| call ``super()`` in your ``setUp()`` and ``tearDown()`` methods, bucause this | ||
| mixin depends on its own setup. |
There was a problem hiding this comment.
Couldn't be that like here?
https://github.com/sunscrapers/djet/blob/master/djet/files.py#L59
There was a problem hiding this comment.
Could you be more precise? Do you suggest using _pre_setup and _post_teardown to for setting up the logging? Or to use InMemoryStorageMixin to store the logging?
|
Yup, I mean `_pre_setup` and `_post_teardown` methods. Thanks to that it
will be easier for user (other programmer) to use the mixin.
…On Thu, Mar 21, 2019 at 8:00 AM Szymon Pyżalski ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/source/getting_started.rst
<#30 (comment)>:
>
Remember that if you want to use assertions e.g. from ``MessagesAssertionsMixin``
you must also add ``middleware_classes`` required by messages to your test case.
We do not add them for you in mixin, because we believe those mixin classes shouldn't
implicitly mess with middleware, because it would make it harder to understand
what and why exactly is happening in your tests.
+You should also note that when using ``LoggingAssertionsMixing`` you need to
+call ``super()`` in your ``setUp()`` and ``tearDown()`` methods, bucause this
+mixin depends on its own setup.
Could you be more precise? Do you suggest using _pre_setup and
_post_teardown to for setting up the logging? Or to use
InMemoryStorageMixin to store the logging?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#30 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA7IUvL3niMtuV0fyo1bH6Pw3pEAHNW2ks5vYy30gaJpZM4aV1dh>
.
|
zefciu
force-pushed
the
logging-assertion
branch
from
bf48fb7
to
67c7782
Compare
Added a simple mixin to test logging in django application
zefciu
force-pushed
the
logging-assertion
branch
from
67c7782
to
f3d9dff
Compare
jellonek
approved these changes
Sep 20, 2019
| @@ -39,3 +39,6 @@ ENV/ | |||
| # logs | |||
| *.log | |||
| .pytest_cache/ | |||
|
|
|||
| # vim | |||
| *.swp | |||
There was a problem hiding this comment.
It's not project specific and imo that's why it should be kept in developer own global git ignore file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple mixin to test logging in django application