[Cart] Add high-level CLI workflows - #136
Draft
KeeganEad wants to merge 11 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OrderLineSettledreceipts against API preparationsStack
Depends on #135.
SDK dependency: superrare/rare-sdk#14.
Validation
npm test: 29 files passed, 173 tests passed, 2 skippednpm run typecheck(vianpm test)npm run test:typecheck(vianpm test)npm run lint -- --no-cachegit diff --checkERC1155_TRANSFER(fulfillment kind 3): passedERC1155_MINT_TO(fulfillment kind 5): passedLive integration status
The successful live runs exercised public catalog lookup, Listing Root publication, API checkout preparation, signed purchase execution, exact ERC-1155 balance changes, and Cart settlement/fulfillment receipt events.
After the Rare API deployment completed, the isolated secondary royalty fixture passed end to end: fresh deployment, mint-to-secondary ownership, nonzero ERC-2981 creator quote, explicit Cart approval, Listing Root publication, checkout preparation, exact 90% seller proceeds and 10% creator royalty lines, signed purchase execution, exact recipient ETH balance deltas, exact
OrderLineSettledreceipt values, and final buyer ownership.The full-suite rerun also exposed a sequencing incompatibility: Rare API now rejects
/v1/cart/listings/previewwith HTTP 409 when Cart does not already have NFT approval. The CLI/SDK listing flow relies on preview to determine required approvals before--yesperforms them, so fresh unapproved ERC-721/ERC-1155 listings cannot currently reach auto-approval. The royalty fixture explicitly preapproves Cart as a setup precondition and therefore verifies the downstream royalty behavior independently.ERC721_MINT_TOremains independently covered by the live suite but the latest run timed out waiting for a catalog SKU for the seeded lazy ERC-721 token. Quote-change-during-checkout coverage remains owned by Rare API because the live CLI fixture has no safe supported mechanism to mutate the royalty quote mid-order.