Markdown from a file #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, got a requirement to load markdown content from a file and couldn't find functionality to do so, thought of adding it.
While exploring an approach to implement the functionality, came across the
Earmark.from_file/1but realised that I would need to do substantial logic change/addition to accommodate it. Therefore, decided to implement the functionality by reading the file contents and piping it to the existing logic.Also added unit tests for all the scenarios previously mentioned.
Additionally, added the compiler suggested,
Enum.map_joinas a replacement to separateEnum.mapandEnum.joinHope this feature would be useful to others and I'm happy to know your suggestions and do the necessary amendments. 😃
Thank you for the awesome Surface library. 👏 💐 💙