Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paginator #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

balduinofernando
Copy link

These changes correct the links in the loop that has "null" as its URL, when you're in the first or last page. So, now it will not show up the previous and next page when we're on the beginning or in the end of the loop and makes the Previous and Next button comes up with the HTML arrows icons.

These changes correct the links in the loop that has "null" as its URL, when you're in the first or last page. So, now it will not show up the previous and next page when we're on the beginning or in the end of the loop.
@svnwa
Copy link
Owner

svnwa commented Mar 24, 2021

I'm a bit confused because the "Previous" and "Next" links should not show up at all because ofthe
v-if="!isFirstOrLastOrDots(link.label) method in line 59, so the link.url !== null wouln't have any effect anyway.

@balduinofernando
Copy link
Author

Yeah, but it's that way, you may test it your self.

I translated your package into bootstrap, and the same thing is happening.

If you are in the first page, the previous link is null, and the url also is null.

I added the suggestions I submitted, and when i am in the first page, the previous button stas hidden, and in the last page too when there's no next link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants