Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to Swift 6 toolchain compile #202

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Adjust to Swift 6 toolchain compile #202

merged 2 commits into from
Jul 18, 2024

Conversation

wangzhizhou
Copy link
Contributor

@wangzhizhou wangzhizhou commented Jul 17, 2024

use the build command provided by Swift Package Index below to verify this package can be migrated to Swift 6 gracefully

env DEVELOPER_DIR=/Applications/Xcode-16.0.0-Beta.3.app xcrun swift build --arch arm64 -Xswiftc -strict-concurrency=complete

Reference this WWDC24 video to make change: https://developer.apple.com/wwdc24/10169

and the Guide to Migrate to Swift 6 on Swift Package Index: https://swiftpackageindex.com/ready-for-swift-6

If this PR is merged, after triggering the Swift Package Index build workflow, you can see the main branch be Safe from data race logo on the homepage of this package as below:

image

Copy link
Contributor

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One change requested

Sources/APNS/APNSClient.swift Outdated Show resolved Hide resolved
@0xTim 0xTim merged commit 36fec7e into swift-server-community:main Jul 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants