Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove platform dance in Package.swift #400

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fabianfett
Copy link
Member

No description provided.

@fabianfett fabianfett requested a review from sebsto October 9, 2024 08:12
Copy link
Contributor

@sebsto sebsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this changes breaks the CI

let package = Package(
name: "swift-aws-lambda-runtime",
platforms: platforms,
platforms: [.macOS(.v15)],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the Swift 6 nightly and swift 6 language mode CI actions

/__w/swift-aws-lambda-runtime/swift-aws-lambda-runtime/Package.swift:7:25: error: reference to member 'v15' cannot be resolved without a contextual type
  5 | let package = Package(
  6 |     name: "swift-aws-lambda-runtime",
  7 |     platforms: [.macOS(.v15)],
    |                         `- error: reference to member 'v15' cannot be resolved without a contextual type
  8 |     products: [
  9 |         // this library exports `AWSLambdaRuntimeCore` and adds Foundation convenience methods

@sebsto
Copy link
Contributor

sebsto commented Oct 9, 2024

@fabianfett can you cross reference the issue you opened (or will open) on the SwiftPM project ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants