[SwiftExtract] Construct .existential for 'any P' types - #901
Merged
ktoso merged 1 commit intoAug 24, 2026
Merged
Conversation
ktoso
reviewed
Aug 24, 2026
| self = .opaque(try SwiftType(someOrAntType.constraint, lookupContext: lookupContext)) | ||
| } else { | ||
| self = .opaque(try SwiftType(someOrAntType.constraint, lookupContext: lookupContext)) | ||
| self = .existential(try SwiftType(someOrAntType.constraint, lookupContext: lookupContext)) |
The someOrAnyType translation had identical branches: both 'some P' and 'any P' produced SwiftType.opaque, so .existential was never constructed and 'any P' rendered as 'some P'. Construct .existential for the 'any' spelling. JExtractSwiftLib already handles .opaque and .existential in shared case arms, so its behavior is unchanged.
kateinoigakukun
force-pushed
the
pr-6cffee35ddcd5b8c28f5c0d7151358c155aa35f6
branch
from
August 24, 2026 05:14
99e080b to
d9a8771
Compare
ktoso
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The someOrAnyType translation had identical branches: both 'some P' and 'any P' produced SwiftType.opaque, so .existential was never constructed and 'any P' rendered as 'some P'. Construct .existential for the 'any' spelling. JExtractSwiftLib already handles .opaque and .existential in shared case arms, so its behavior is unchanged.