Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine API #132

Merged
merged 14 commits into from
Oct 1, 2024
Merged

Engine API #132

merged 14 commits into from
Oct 1, 2024

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Oct 1, 2024 •
edited
Loading

The old Runtime-based API family has the following problems:

  • A runtime is always associated with a single Store
  • Entities to be imported at instantiation are held by Runtime. We should allow specifying imports per instantiation.
    • Holding imported entities in Runtime makes the future async suspendable support
  • There are two function concepts: HostFunction and Function even though they both are lowered into InternalFunction at runtime.

This PR adds a brand new Engine API family to replace Runtime APis

@kateinoigakukun
Engine API: Add Engine type to replace Runtime
ddb56a8 
The new API is intended to allow the following future improvements:
- Support multiple `Store` instances in a single `Engine` instance.
- Async (suspendable) execution.
without breaking the existing API.
@kateinoigakukun
Engine API: Make Runtime as a thin wrapper around Engine
897c762
@kateinoigakukun
Engine API: Migrate Execution internals
f43fb1c
@kateinoigakukun
Engine API: Add Module/instantiate(store:imports:) method
54f6b09
@kateinoigakukun
Engine API: Migrate Spectest suite to use Engine
dc824d7
@kateinoigakukun
Engine API: Migrate CLI module
5263597
@kateinoigakukun
Fix CMake build
5854adf
@kateinoigakukun
Engine API: Split const evaluation into a separate file
cb71fdf 
This is a preparation for the future removal of Runtime.swift.
@kateinoigakukun
Engine API: Migrate WITOverlayGenerator
b946b8e
@kateinoigakukun
Engine API: Migrate all Runtime usage in ./Tests
f0c1ea8
@kateinoigakukun
Engine API: Migrate examples to the new API
f2e60ab
@kateinoigakukun
Engine API: Migrate fuzzing targets
b667d3b
@kateinoigakukun
Engine API: Minor documentation updates and add accessors for entities
e3f8a40
@kateinoigakukun
Fix deinit against uninited InstanceEntity
cb9f25f
@kateinoigakukun kateinoigakukun marked this pull request as ready for review October 1, 2024 19:17
@kateinoigakukun kateinoigakukun merged commit b299db9 into main Oct 1, 2024
9 checks passed
@kateinoigakukun kateinoigakukun deleted the katei/vmgen-imm branch October 1, 2024 19:32
@kateinoigakukun kateinoigakukun mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kateinoigakukun