Record paired device last connection time - #644
Merged
Conversation
Contributor
Author
|
Independent exact-head review completed for The reviewer confirmed the earlier out-of-order Windows persistence finding is fixed and reported no actionable findings on the updated head. Frontend, macOS app/DMG, and Windows NSIS CI all pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #643
What changed
connection.pinginto a connection event with the validated device ID and desktop timestamplastSeenAtand an optional Remote name in one transaction before publishing either value in memoryRaw Bluetooth subscriptions and failed authentication do not update device metadata. Existing ping acknowledgements and the
name_update_failedresponse remain compatible.Validation
npm run lintnpm test(74 tests)npm run buildcargo fmt --manifest-path src-tauri/Cargo.toml --checkcargo clippy --manifest-path src-tauri/Cargo.toml --all-targets -- -D warningscargo test --manifest-path src-tauri/Cargo.toml(211 unit tests, 2 config tests)