Fix Remote keyboard shortcut injection - #649
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Remote already sends the PC's canonical payload, for example
keys: ["Ctrl", "A"]. Enigo's Windows conversion kept the Shift-state byte returned for uppercase Unicode characters and treated the combined value as a virtual-key code. PC also replayed Ctrl inside the shortcut even thoughkeyboard.modifierDownalready held it.Validation
npm run lintnpm test(74 Vitest tests and 5 release-feed tests passed)npm run buildcargo fmt --manifest-path src-tauri/Cargo.toml --checkcargo clippy --locked --manifest-path src-tauri/Cargo.toml --all-targets -- -D warningscargo test --locked --manifest-path src-tauri/Cargo.toml(217 unit tests and 2 config tests passed)npm run tauri build -- --bundles nsis --no-signsrc/remote/RemoteSession.test.ts(12 tests passed)Physical Windows and macOS shortcut checks remain for release validation.
Closes #647