Skip to content

fix: restore live typing focus after Enter - #112

Merged
enaboapps merged 1 commit into
mainfrom
codex/live-enter-focus-111
Aug 25, 2026
Merged

fix: restore live typing focus after Enter#112
enaboapps merged 1 commit into
mainfrom
codex/live-enter-focus-111

Conversation

@enaboapps

Copy link
Copy Markdown
Contributor

Summary

  • defer live text input focus restoration until React Native has committed the editable state
  • clear stale native focus bookkeeping with a bounded blur/focus sequence
  • cancel pending restoration across submissions, mode/session changes, and unmount
  • preserve Enter delivery, success clearing, failure retention, and retry behavior

Closes #111

Validation

pm run validate (pass; Expo Doctor 21/21)

px expo config --type public (pass; version/config unchanged)

  • focused Jest coverage for focus scheduling, cancellation, both Enter paths, failure/retry, and session lifecycle (pass)
  • git diff --check (pass)

Physical testing

  • Android/iOS software-keyboard and assistive-technology smoke checks remain pending; no automated real-input injection was performed.

Compatibility

  • no protocol, BLE, command payload, storage, dependency, native configuration, or version changes

@enaboapps

Copy link
Copy Markdown
Contributor Author

Independent latest-head review

Reviewed exact head 90ad94f.

No actionable findings. Review covered the post-commit/two-frame focus timing, stale-focus blur/focus recovery, cancellation on later submission/mode change/session replacement/unmount, successful and failed Enter plus Retry Enter, and the no-backspace invariant. Focused tests passed: 3 suites, 31 tests.

Physical Android/iOS keyboard and assistive-technology checks remain pending as disclosed in the PR.

@enaboapps

Copy link
Copy Markdown
Contributor Author

CI result

All required checks are green on exact reviewed head 90ad94f:

  • validation: pass
  • Android clean prebuild + Gradle debug build: pass
  • iOS clean prebuild + CocoaPods + simulator build: pass

The PR remains draft and unmerged pending explicit approval and the documented physical keyboard/assistive-technology checks.

@enaboapps
enaboapps marked this pull request as ready for review August 25, 2026 11:41
@enaboapps
enaboapps merged commit 8a98944 into main Aug 25, 2026
3 checks passed
@enaboapps
enaboapps deleted the codex/live-enter-focus-111 branch August 25, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore live typing focus after Enter

2 participants