Skip to content

fix: detect stale PC disconnections - #114

Merged
enaboapps merged 3 commits into
mainfrom
codex/detect-pc-disconnect-113
Aug 25, 2026
Merged

fix: detect stale PC disconnections#114
enaboapps merged 3 commits into
mainfrom
codex/detect-pc-disconnect-113

Conversation

@enaboapps

Copy link
Copy Markdown
Contributor

Summary

  • verify idle BLE connections with a bounded status-characteristic probe
  • enter reconnecting before cleanup after native, notification, write, or health-check failures
  • defer health checks during protocol work and reset them after healthy activity
  • distinguish dropped responses from failed native writes
  • add sanitized diagnostics and accessibility and physical-test guidance

Closes #113

Validation

pm run validate (pass: 49 suites, 389 tests, Expo Doctor 21/21)

  • focused connection, transport, protocol, and Remote presentation tests (pass: 96 tests before final timeout-cancellation addition)

px expo config --type public (pass; version 1.0.0/build 17 and native configuration unchanged)

  • git diff --check (pass)

Physical testing

  • Android and iOS checks for PC Quit, PC Disconnect, Bluetooth loss, out-of-range loss, failed writes, dropped responses, announcements, and automatic recovery remain pending. Automated tests use fake BLE transports and do not inject real input.

Compatibility

  • no protocol v1, PC application, pairing data, BLE identifier, permission, dependency, native configuration, or version changes

@enaboapps

Copy link
Copy Markdown
Contributor Author

Review follow-up at b02640d:\n\n- Resolved the recovery-watchdog timing finding by coordinating health probes before/after background profile requests.\n- Classified pointer-profile native write failures separately so reconnecting begins immediately during both initial negotiation and recovery.\n- Added an absolute 22-second recovery presentation deadline so slow healthy probes cannot prolong the unavailable-state decision.\n- Added regression coverage for stale loss during a pending recovery response, initial/recovery write failures, and slow healthy probes.\n\nValidation: npm run validate passed (49 suites, 393 tests; Expo Doctor 21/21). Independent latest-head re-review and refreshed CI are in progress.

@enaboapps

Copy link
Copy Markdown
Contributor Author

Final handoff at b02640d:\n\n- Independent latest-head review: no actionable findings.\n- Local validation: npm run validate passed (49 suites, 393 tests; Expo Doctor 21/21).\n- CI run 32848600621: validate, Android native build, and iOS native build all passed.\n\nThe PR remains draft and unmerged pending explicit approval.

@enaboapps
enaboapps marked this pull request as ready for review August 25, 2026 13:11
@enaboapps
enaboapps merged commit 680bde0 into main Aug 25, 2026
3 checks passed
@enaboapps
enaboapps deleted the codex/detect-pc-disconnect-113 branch August 25, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect stale PC disconnections in Remote

2 participants