Skip to content

fix: deliver Stop movement commands - #118

Merged
enaboapps merged 2 commits into
mainfrom
codex/fix-stop-movement-117
Aug 25, 2026
Merged

fix: deliver Stop movement commands#118
enaboapps merged 2 commits into
mainfrom
codex/fix-stop-movement-117

Conversation

@enaboapps

Copy link
Copy Markdown
Contributor

Closes #117

Summary

  • send every mouse.repeat.stop command in acknowledged mode accepted by Switchify PC
  • clear local repeat state once, then prioritize PC delivery before Android bridge deactivation
  • preserve serialized stop/start ordering across the button, other controls, physical switches, cleanup, and session replacement

Validation

  • npm run validate
    • 49 test suites passed
    • 396 tests passed
    • Expo Doctor 21/21 checks passed
  • Physical Windows, macOS, Android, and iOS repeat-stop checks remain to be completed

No PC, protocol schema, BLE identifier, storage, dependency, permission, or native configuration changes.

@enaboapps

Copy link
Copy Markdown
Contributor Author

Latest-head update (9b4ac32):\n\n- Resolved the independent review finding by reserving the stop and clearing the local repeat state synchronously at the stopRepeat() call boundary.\n- Preserved serialized ordering: repeat start completes, the acknowledged PC stop is attempted, then Android bridge deactivation runs.\n- Added regression coverage for a stop requested while bridge activation is pending, including a duplicate stop.\n- Full local validation:
pm run validate — 49 suites / 397 tests passed; Expo Doctor 21/21.\n- Focused validation: 3 suites / 75 tests passed.\n- git diff --check passed.\n- Independent re-review of exact head 9b4ac32: no actionable findings.\n\nPhysical Android/iOS and Windows/macOS hardware checks remain for manual verification.

@enaboapps

Copy link
Copy Markdown
Contributor Author

Latest-head CI is green for 9b4ac32:\n\n- validate: passed\n- native-projects (Android): passed\n- native-projects (iOS): passed\n\nImplementation remains in draft and unmerged pending explicit approval.

@enaboapps
enaboapps marked this pull request as ready for review August 25, 2026 18:48
@enaboapps
enaboapps merged commit c3d18fb into main Aug 25, 2026
3 checks passed
@enaboapps
enaboapps deleted the codex/fix-stop-movement-117 branch August 25, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Stop movement delivery

2 participants