Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support time range and only combining some blocks in combine_h5 #6306

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

nilsdeppe
Copy link
Member

Proposed changes

This is useful for visualizations since getting tetrahedral connectivity to work is a lot easier with a single h5 file. These changes are part of a bigger pipeline support where you can combine some blocks into a new H5 file, then run a new bit of python code, generate-tetrahedral-connectivity, and then more easily to volume renderings in ParaView.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

It ddidn't depend on anything in Creators and so creates a pretty strong tie to
a lot of the code. This is because Creators depends on things like H5.
This is useful for reducing the amount of volume data that gets rendered.
@nilsdeppe nilsdeppe merged commit f199452 into sxs-collaboration:develop Sep 27, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants