Enable BBH ID control of CoM and Padm. #6315
Merged
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
With recent changes to the calculation of the center of mass and linear momentum integrals, we are now ready to enable their control by default. We also take this opportunity to set the control residual tolerance to
1.e-4
instead of1.e-6
, which makes more sense given that junk radiation effects are on the order of1.e-3
.For an equal-mass non-spinning case with default settings, the control loop currently reaches the residual tolerance in just 3 iterations. In human time, this takes ~17 minutes on 1 node of CaltechHPC.
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments