test: add a hosted-runner trezor-emu path alongside the self-hosted one - #692
Draft
mdozhdev wants to merge 1 commit into
Draft
test: add a hosted-runner trezor-emu path alongside the self-hosted one#692mdozhdev wants to merge 1 commit into
mdozhdev wants to merge 1 commit into
Conversation
`trezor-emu` needs Docker and the iOS Simulator on one machine, which GitHub-hosted macOS runners cannot provide. It is the last job holding the self-hosted Mac open. Adds the same suite as a second `suite` choice, with the emulator stack on an `ubuntu-latest` runner reached over Tailscale: | job | runner | |---|---| | `trezor-stack` | ubuntu — bitcoind, electrs and Trezor User Env; holds until the tests finish | | `trezor-emu-remote` | macos-latest — the same xcodebuild invocation | The suite addresses Bridge, the User Env controller, electrs and bitcoind as 127.0.0.1 from inside the Simulator, across five call sites in BitkitUITests/TrezorBridgeDashboardUITests.swift that are not all configurable. The Mac job relays those six ports onto loopback instead, so the test and the app are unchanged — no Swift and no Info.plist edits. Verified against the pinned trezor-user-env image on Linux: Bridge binds 0.0.0.0 rather than loopback, origin checking is patched out, and a full acquire -> GetFeatures -> release round trip works off-host and through the relay, as does emulator-press-yes over the controller websocket. Nothing existing changes. `trezor-emu` is untouched and still dispatchable. The two new jobs must not depend on each other: `trezor-stack` only finishes once the tests are done, so a dependency either way deadlocks. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
trezor-emuneeds Docker and the Simulator on one machine, so it runs on the self-hosted Mac — the last job keeping it alive.Adds the same suite as a second
suitechoice: emulator stack onubuntu-latest, Simulator onmacos-latest, joined over Tailscale. Same shape as #689.The suite reaches Bridge, the User Env controller, electrs and bitcoind as
127.0.0.1from inside the Simulator, so the Mac job relays those ports onto loopback rather than making the suite stack-aware. No Swift orInfo.plistchanges.trezor-emuis untouched and still dispatchable. Dispatch-only, so nothing runs unless asked.Linked Issues/Tasks