Skip to content

Commit

Permalink
chore: Make cloud-connector image configurable (#156)
Browse files Browse the repository at this point in the history
  • Loading branch information
tembleking authored Jan 19, 2023
1 parent 66e8002 commit 448bde6
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 9 deletions.
1 change: 1 addition & 0 deletions examples/single-account-ecs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ $ terraform apply
| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| <a name="input_benchmark_regions"></a> [benchmark\_regions](#input\_benchmark\_regions) | List of regions in which to run the benchmark. If empty, the task will contain all aws regions by default. | `list(string)` | `[]` | no |
| <a name="input_cloud_connector_image"></a> [cloud\_connector\_image](#input\_cloud\_connector\_image) | Image to use for the cloud connector. If empty, the default image will be used. | `string` | `"quay.io/sysdig/cloud-connector:latest"` | no |
| <a name="input_cloudtrail_is_multi_region_trail"></a> [cloudtrail\_is\_multi\_region\_trail](#input\_cloudtrail\_is\_multi\_region\_trail) | true/false whether cloudtrail will ingest multiregional events | `bool` | `true` | no |
| <a name="input_cloudtrail_kms_enable"></a> [cloudtrail\_kms\_enable](#input\_cloudtrail\_kms\_enable) | true/false whether cloudtrail delivered events to S3 should persist encrypted | `bool` | `true` | no |
| <a name="input_cloudtrail_s3_bucket_expiration_days"></a> [cloudtrail\_s3\_bucket\_expiration\_days](#input\_cloudtrail\_s3\_bucket\_expiration\_days) | Number of days that the logs will persist in the bucket | `number` | `5` | no |
Expand Down
1 change: 1 addition & 0 deletions examples/single-account-ecs/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ module "cloud_connector" {
ecs_vpc_subnets_private_ids = local.ecs_vpc_subnets_private_ids
ecs_task_cpu = var.ecs_task_cpu
ecs_task_memory = var.ecs_task_memory
image = var.cloud_connector_image

tags = var.tags
depends_on = [local.cloudtrail_sns_arn, module.ssm]
Expand Down
10 changes: 8 additions & 2 deletions examples/single-account-ecs/variables.tf
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@


#---------------------------------
# optionals - with defaults
#---------------------------------
Expand Down Expand Up @@ -112,6 +110,14 @@ variable "benchmark_regions" {
default = []
}

#
# cloud connector connector configuration
#
variable "cloud_connector_image" {
type = string
description = "Image to use for the cloud connector. If empty, the default image will be used."
default = "quay.io/sysdig/cloud-connector:latest"
}

#
# general
Expand Down
9 changes: 5 additions & 4 deletions modules/services/cloud-connector-ecs/ecs-service.tf
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ resource "aws_ecs_service" "service" {
security_groups = [aws_security_group.sg.id]
}

desired_count = 1
launch_type = "FARGATE"
task_definition = aws_ecs_task_definition.task_definition.arn
tags = var.tags
desired_count = 1
launch_type = "FARGATE"
task_definition = aws_ecs_task_definition.task_definition.arn
wait_for_steady_state = true
tags = var.tags
}


Expand Down
4 changes: 2 additions & 2 deletions use-cases/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ With both examples `single` and `org`, you can customize the desired features to

### unified-compliance only

If you just want [CIS Unified Compliance Benchmarks](https://docs.sysdig.com/en/docs/sysdig-secure/posture/compliance/compliance-unified-/)
you can make use of
If you just want [CIS Unified Compliance Benchmarks](https://docs.sysdig.com/en/docs/sysdig-secure/posture/compliance/compliance-unified-/)
you can make use of

- [Single-Account Compliance Role Setup](./compliance-role-single-account.md)
- [Organizational Compliance Role setup](./compliance-role-organizational.md)
2 changes: 1 addition & 1 deletion use-cases/compliance-role-organizational.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ provider "aws" {
module "sysdig-sfc" {
source = "sysdiglabs/secure-for-cloud/aws//modules/services/cloud-bench"
name = "sysdig-compliance-role" # optional
is_organizational=true
}
```

0 comments on commit 448bde6

Please sign in to comment.