New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modular): add modular support for cdr/ciem #35

Merged

jose-pablo-camacho merged 35 commits into master from feat/modular/cdr-ciem

Sep 17, 2024

Contributor

jose-pablo-camacho commented Sep 5, 2024 •

edited

Loading

xref: https://sysdig.atlassian.net/browse/SSPROD-46143

This is a draft PR for now, it contains the refactor for GCP modular onboarding specifically for CDR and CIEM.
It is important to notice that this will be cleaned up until the Onboarding + CSPM terraform snippets are ready, for now ignore all the commented sections, the uncommented sections are the ones that will be part of the new snippets.

jose-pablo-camacho added 5 commits

September 5, 2024 14:45


          feat(modular): add modular support for cdr/ciem


          feat(modular): add modular support for cdr/ciem

285d3ab


          feat(modular): add modular support for cdr/ciem

86f419c


          feat(modular): add modular support for cdr/ciem

5ff322f


          feat(modular): add modular support for cdr/ciem

519d695

haresh-suresh reviewed

View reviewed changes

modules/integrations/webhook-datasource/main.tf Outdated Show resolved Hide resolved

haresh-suresh reviewed

View reviewed changes

modules/integrations/webhook-datasource/main.tf Outdated Show resolved Hide resolved

haresh-suresh reviewed

View reviewed changes

test/examples/single_account_cdr_test/webhook_datasource.tf Outdated Show resolved Hide resolved

haresh-suresh reviewed

View reviewed changes

test/examples/single_account_cdr_test/webhook_datasource.tf Outdated Show resolved Hide resolved

haresh-suresh reviewed

View reviewed changes

test/examples/organization_cdr_test/webhook_datasource.tf Outdated Show resolved Hide resolved

haresh-suresh reviewed

View reviewed changes

test/examples/organization_cdr_test/webhook_datasource.tf Outdated Show resolved Hide resolved

haresh-suresh reviewed

View reviewed changes

modules/integrations/webhook-datasource/versions.tf Outdated Show resolved Hide resolved

haresh-suresh reviewed

View reviewed changes

modules/integrations/webhook-datasource/README.md Outdated Show resolved Hide resolved

haresh-suresh reviewed

View reviewed changes

modules/integrations/webhook-datasource/main.tf Outdated Show resolved Hide resolved

haresh-suresh reviewed

View reviewed changes

modules/integrations/webhook-datasource/organizational.tf Outdated Show resolved Hide resolved

jose-pablo-camacho and others added 15 commits

September 10, 2024 14:22


          feat(modular): address feedback for modular support for cdr/ciem

72b6314


          Merge branch 'master' into feat/modular/cdr-ciem

f7be89a


          adding modular onboarding module

e51c02d


          fix var refns

80b782a


          adding modular onboarding example


          adding config posture module for modular onboarding

7a07625


          updating README

5581c6a


          fix role naming & version metadata

4abc7b2


          updating examples for onboarding & cspm org

b4d8e07


          cleanup foundational READMEs

e9a212d


          use external_id datasource

2885ccc


          update README

628a2d6


          remove mgmt_group_ids in cspm module

211a8de


          bump sysdig provider version to be consistent & have latest datasources

ec938f0


          updating examples

b37fe73

Contributor

haresh-suresh commented Sep 11, 2024 •

edited

Loading

@jose-pablo-camacho We should rename the integration to integrations/pub-sub and the examples to pub-sub.tf. I think the pattern we have followed is the actual name of the event integration in the specific cloud.

haresh-suresh and others added 4 commits

September 11, 2024 14:15


          add explicit dependency

dfd45da


          feat(modular): address feedback for modular support for cdr/ciem, reb…

e834d16

…ase and cleanup


          Merge branch 'master' into feat/modular/cdr-ciem

9acee0d


          feat(modular): address feedback for modular support for cdr/ciem, reb…

72aafe0

…ase and cleanup

Contributor Author

jose-pablo-camacho commented Sep 11, 2024

@jose-pablo-camacho We should rename the integration to integrations/pub-sub and the examples to pub-sub.tf. I think the pattern we have followed is the actual name of the event integration in the specific cloud.

I have changed the name from webhook-datasource to pub-sub.


          feat(modular): address feedback for modular support for cdr/ciem, reb…

4d60c2d

…ase and cleanup

jose-pablo-camacho marked this pull request as ready for review

September 11, 2024 22:25

jose-pablo-camacho requested a review from a team as a code owner

September 11, 2024 22:25

ravinadhruve10 reviewed

View reviewed changes

test/examples/organization_cdr_test/pub-sub.tf Outdated Show resolved Hide resolved

test/examples/single_account_cdr_test/pub-sub.tf Outdated Show resolved Hide resolved

test/examples/modular_organization/pub-sub.tf Outdated Show resolved Hide resolved

test/examples/modular_single_project/pub-sub.tf Outdated Show resolved Hide resolved

jose-pablo-camacho added 2 commits

September 13, 2024 16:41


          feat(modular): address feedback for modular support for cdr/ciem, reb…

0af9292

…ase and cleanup


          feat(modular): address feedback for modular support for cdr/ciem, reb…

d5c0e11

…ase and cleanup

ravinadhruve10 reviewed

View reviewed changes

Contributor

ravinadhruve10 left a comment

Few review comments (for webhook module)

modules/integrations/pub-sub/README.md Show resolved Hide resolved

modules/integrations/pub-sub/README.md Show resolved Hide resolved

modules/integrations/pub-sub/README.md Show resolved Hide resolved

modules/integrations/pub-sub/outputs.tf Show resolved Hide resolved

modules/integrations/pub-sub/README.md Show resolved Hide resolved

modules/integrations/pub-sub/variables.tf Outdated Show resolved Hide resolved

modules/integrations/pub-sub/README.md Show resolved Hide resolved


          feat(modular): address feedback for modular support for cdr/ciem, reb…

c0ede5f

…ase and cleanup

haresh-suresh requested review from haresh-suresh and ravinadhruve10

September 16, 2024 23:10

haresh-suresh reviewed

View reviewed changes

modules/integrations/pub-sub/README.md Show resolved Hide resolved

haresh-suresh reviewed

View reviewed changes

modules/integrations/pub-sub/variables.tf Outdated Show resolved Hide resolved

haresh-suresh reviewed

View reviewed changes

modules/integrations/pub-sub/main.tf Show resolved Hide resolved

haresh-suresh reviewed

View reviewed changes

modules/integrations/pub-sub/main.tf Outdated Show resolved Hide resolved

haresh-suresh reviewed

View reviewed changes

modules/integrations/pub-sub/main.tf Outdated Show resolved Hide resolved

haresh-suresh reviewed

View reviewed changes

modules/integrations/pub-sub/organizational.tf Outdated Show resolved Hide resolved

Contributor

haresh-suresh commented Sep 17, 2024

Left a few comments, you will also need to rebase & address some merge conflicts based on latest master.
The foundational PR is now merged.

jose-pablo-camacho added 4 commits

September 17, 2024 09:27


          feat(modular): address feedback for modular support for cdr/ciem, reb…

30d4786

…ase and cleanup


          enhance(modular): use org domain instead of org ID for gcp api enable…

634ce2a

…ment (#40)


          Merge branch 'master' into feat/modular/cdr-ciem

1a26d8f


          rebase and merge fix

11655a0

haresh-suresh approved these changes

View reviewed changes

Contributor

haresh-suresh left a comment

Good work @jose-pablo-camacho ! LGTM 👍

jose-pablo-camacho merged commit e35f083 into master

8 checks passed

jose-pablo-camacho deleted the feat/modular/cdr-ciem branch

September 17, 2024 16:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet