Option to skip creation of aggregated output if input set is empty #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Tanasenko <atg.sleepless@gmail.com>
|
Or maybe it's better to add a InputSet#hasInputs() method and control this from application code? |
| @@ -133,4 +133,18 @@ public void testEmpty() throws Exception { | |||
| Assert.assertEquals(1, indexer.outputs.size()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testEmptyNoCreate() throws Exception { | |||
There was a problem hiding this comment.
Please add a test for incremental delete of an aggregate output created during a prior build.
|
I am not sure, to be honest. On one hand, the less code the client has to write, the better, so if we can encapsulate correct behaviour in the library, we should do that. On the other hand, I can imagine some clients may want/need to create aggregate outputs for empty input sets... but I can't think of practical usecase... sigh. api design is hard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will also address part of issue #15