New Feature: Plugin lookup in execution contexts #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugins generally don't inject/compose other plugins but I see nothing wrong with general site injection. Though I'd use the JSR330 annotations (@javax.inject.Inject) instead of the ones we made up in Maven-land (@component). |
|
I've made some progress, including towards fixing #252, but I've temporarily given up due to takari/takari-lifecycle#109 (So I probably have some dumb syntax errors in this right now) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
executeblocks in languages (specifically Ruby that I'm interested in) can't declare java@Componentannotations to access other maven plugins, this feature would allow a target language to use a new method on theExecutionContexto retreive instances from the IoC container.Would need a bit of polish, but I'm gauging interest before I spend time finishing this.