Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utils.py #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ZhanruiLiang
Copy link

The existing one won't work.

The existing one won't work.
@1mpossibleHacker
Copy link

I agree

@taki0112
Copy link
Owner

I've checked, but it works
Why did you add the comma?

@ZhanruiLiang
Copy link
Author

I should've said "won't work as expected". ('true') is the same as 'true' but here I believe the intent here is to have a tuple which should be ('true',). Otherwise you've had used the parens. The current way somehow works but it may surprise users because 'rue' in ('true'), 'u' in ('true'), etc. will also evaluate to True.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants