Skip to content

fix(config): Added config.oidc.jwks_endpoint - #620

Open
MisheyDev wants to merge 1 commit into
tale:mainfrom
MisheyDev:bugfix/jwks-endpoint
Open

fix(config): Added config.oidc.jwks_endpoint#620
MisheyDev wants to merge 1 commit into
tale:mainfrom
MisheyDev:bugfix/jwks-endpoint

Conversation

@MisheyDev

Copy link
Copy Markdown

Added support to manually configure a JWKS endpoint w/i OIDC config.
See: #619

@MisheyDev
MisheyDev requested a review from tale as a code owner August 24, 2026 02:53
@github-actions github-actions Bot added the Config Related to Headplane specific configuration label Aug 24, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — the wiring is correct, but the new option isn't documented.

Reviewed changes

  • oidc.jwks_endpoint config option — adds an optional jwks_endpoint to both the full and partial OIDC schemas and passes it through buildOidc as the existing jwksUri field on OidcConfig.

The code change is minimal and matches the surrounding patterns exactly. provider.ts already had first-class support for a manual jwksUri (in fullManual, the discovery override, and the JWKS resolver), so this closes the gap in #619 without any behavioral risk.

ℹ️ jwks_endpoint is not documented

The new option is invisible to users, because the manual-endpoint references elsewhere in the repo weren't updated. config.example.yaml (the manual endpoints block) and docs/features/sso.md (both the "these are usually auto-discovered" list and the "Missing endpoints" troubleshooting entry) enumerate authorization_endpoint, token_endpoint, and userinfo_endpoint but omit jwks_endpoint. Since this PR's purpose is to let users supply a JWKS URL that discovery can't resolve, the option should be documented alongside the other manual endpoints.

Technical details
# Document oidc.jwks_endpoint

## Affected sites
- config.example.yaml:222-224 — manual endpoint block omits jwks_endpoint
- docs/features/sso.md:71-74 — "these are usually auto-discovered" list omits jwks_endpoint
- docs/features/sso.md:354-356 — "Missing endpoints" troubleshooting omits jwks_endpoint
- nix/options.nix:357-400 — Nix module mirrors some oidc endpoints (optional: add jwks_endpoint here too)

## Required outcome
- jwks_endpoint appears alongside the other manual endpoint overrides in config.example.yaml and docs/features/sso.md

Pullfrog  | Fix it ➔View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) | 𝕏

@MisheyDev MisheyDev changed the title Added config.oidc.jwks_endpoint fix(config): Added config.oidc.jwks_endpoint Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Config Related to Headplane specific configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant