Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tangle Chain Names + Remove redundant chains #1969

Merged
merged 7 commits into from
Jan 22, 2024
Merged

Update Tangle Chain Names + Remove redundant chains #1969

merged 7 commits into from
Jan 22, 2024

Conversation

vutuanlinh2k2
Copy link
Contributor

@vutuanlinh2k2 vutuanlinh2k2 commented Jan 19, 2024 •
edited
Loading

Summary of changes

Provide a detailed description of proposed changes.

  • Update Tangle Chain Names + Remove redundant chains

Proposed area of change

Put an x in the boxes that apply.

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/tangle-dapp
  • apps/testnet-leaderboard
  • apps/faucet
  • apps/zk-explorer
  • libs/webb-ui-components

Reference issue to close (if applicable)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Code Checklist

Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@netlify Netlify
Copy link

netlify bot commented Jan 19, 2024 •
edited
Loading

✅ Deploy Preview for hubble-stats ready!

Name Link
🔨 Latest commit acbbf96
🔍 Latest deploy log https://app.netlify.com/sites/hubble-stats/deploys/65ae62b5d223420008431962
😎 Deploy Preview https://deploy-preview-1969--hubble-stats.netlify.app/500
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 19, 2024 •
edited
Loading

✅ Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit acbbf96
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/65ae62b5878b5900089eeee7
😎 Deploy Preview https://deploy-preview-1969--tangle-dapp.netlify.app/500
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 19, 2024 •
edited
Loading

✅ Deploy Preview for zkexplorer ready!

Name Link
🔨 Latest commit acbbf96
🔍 Latest deploy log https://app.netlify.com/sites/zkexplorer/deploys/65ae62b55c847f00081c43cd
😎 Deploy Preview https://deploy-preview-1969--zkexplorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vutuanlinh2k2 vutuanlinh2k2 marked this pull request as ready for review January 19, 2024 10:05
@vutuanlinh2k2 vutuanlinh2k2 changed the title chore: remove redundant chains Update Tangle Chain Names + Remove redundant chains Jan 19, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 19, 2024 •
edited
Loading

✅ Deploy Preview for testnet-leaderboard ready!

Name Link
🔨 Latest commit acbbf96
🔍 Latest deploy log https://app.netlify.com/sites/testnet-leaderboard/deploys/65ae62b53fdbd90008f8c7f2
😎 Deploy Preview https://deploy-preview-1969--testnet-leaderboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

✅ Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @vutuanlinh2k2

Name Link
🔨 Latest commit 57ca136960559b0395f3173a3070d448732a801f
🔍 Latest deploy log https://app.netlify.com/sites/hubble-bridge/deploys/65aa4be06df68c0a1a9fdc58
😎 Deploy Preview https://65aa4be06df68c0a1a9fdc58--hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions GitHub Actions
Copy link

✅ Deploy Preview for webb faucet is ready! Thanks for the contribution @vutuanlinh2k2

Name Link
🔨 Latest commit 57ca136960559b0395f3173a3070d448732a801f
🔍 Latest deploy log https://app.netlify.com/sites/webb-faucet/deploys/65aa4c79643bc309da43a3ed
😎 Deploy Preview https://65aa4c79643bc309da43a3ed--webb-faucet.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

AtelyPham
AtelyPham reviewed Jan 19, 2024
View reviewed changes
libs/dapp-types/src/SubstrateChainId.ts Outdated
Comment on lines 4 to 5
LocalTangleNative = 1081, // Local Tangle Native
TangleTestnetNative = 1081, // Live Tangle Native Testnet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove one of these two enum values since they share the same value.

AtelyPham
AtelyPham requested changes Jan 19, 2024
View reviewed changes
Copy link
Member

@AtelyPham AtelyPham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment.

@drewstone
Copy link
Contributor

Merge conflicts here and then good to go

@github-actions GitHub Actions
Copy link

✅ Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @vutuanlinh2k2

Name Link
🔨 Latest commit 5ae19da8e6aaf093d5a929f940e25b9f1b3e25a4
🔍 Latest deploy log https://app.netlify.com/sites/hubble-bridge/deploys/65ae61d20d705f00ae1d70cd
😎 Deploy Preview https://65ae61d20d705f00ae1d70cd--hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions GitHub Actions
Copy link

✅ Deploy Preview for webb faucet is ready! Thanks for the contribution @vutuanlinh2k2

Name Link
🔨 Latest commit 5ae19da8e6aaf093d5a929f940e25b9f1b3e25a4
🔍 Latest deploy log https://app.netlify.com/sites/webb-faucet/deploys/65ae6202119628008f6c4fab
😎 Deploy Preview https://65ae6202119628008f6c4fab--webb-faucet.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions GitHub Actions
Copy link

✅ Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @vutuanlinh2k2

Name Link
🔨 Latest commit acbbf96dd05dc4dfa7b2964adcf517ef60e5bb94
🔍 Latest deploy log https://app.netlify.com/sites/hubble-bridge/deploys/65ae647574d7a600849f46f6
😎 Deploy Preview https://65ae647574d7a600849f46f6--hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions GitHub Actions
Copy link

✅ Deploy Preview for webb faucet is ready! Thanks for the contribution @vutuanlinh2k2

Name Link
🔨 Latest commit acbbf96dd05dc4dfa7b2964adcf517ef60e5bb94
🔍 Latest deploy log https://app.netlify.com/sites/webb-faucet/deploys/65ae64d13486e7009ac7a249
😎 Deploy Preview https://65ae64d13486e7009ac7a249--webb-faucet.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@AtelyPham AtelyPham merged commit 994b1f0 into develop Jan 22, 2024
25 checks passed
@AtelyPham AtelyPham deleted the linh/update-chains branch January 22, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtelyPham AtelyPham AtelyPham approved these changes

@yurixander yurixander yurixander approved these changes

@drewstone drewstone Awaiting requested review from drewstone

@devpavan04 devpavan04 Awaiting requested review from devpavan04 devpavan04 is a code owner

Assignees

@vutuanlinh2k2 vutuanlinh2k2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Update Chain Name in code + Remove redundant chains
4 participants
@vutuanlinh2k2 @drewstone @AtelyPham @yurixander