Masp Batch Deposits #453
Masp Batch Deposits #453
Conversation
|
Can you also link SPEC for MASP Relayer Integration to this PR..? |
|
base relayer integrations spec: https://www.notion.so/MASP-Relayer-Integration-8d4f6e4c8e124dc1b87bac4766783bd5 batch deposit specific spec: https://www.notion.so/hicommonwealth/Batched-Reward-Tree-Processing-7d51b34188584288af9266e7f2a06542 |
| pub events_watcher: EventsWatcherConfig, | ||
| /// The type of the optional signing backend used for signing proposals. It can be None for pure Tx relayers | ||
| #[serde(rename(serialize = "proposalSigningBackend"))] | ||
| pub proposal_signing_backend: Option<ProposalSigningBackendConfig>, |
There was a problem hiding this comment.
Is this needed or used anywhere on the proxy config? I recommend starting with only the things we use so these objects don't get clogged.
| let wasm_path = "../../tests/solidity-fixtures/batch-tree/4/batchMerkleTreeUpdate_4.wasm"; | ||
| let prover = MaspBatchProver::new(zkey_path, wasm_path); | ||
|
|
||
| // pre-generated inputs |
There was a problem hiding this comment.
Please instruct how to generate these pre-generated inputs too. All pre-generated fixture tests should be reproducible from the first step.
| let is_known_root = | ||
| wrapper.contract.is_known_root(root).call().await?; | ||
| tracing::trace!("Is known root: {:?}", is_known_root); | ||
| if event_data.leaf_index.as_u32() % 2 == 0 { |
There was a problem hiding this comment.
If we are requiring the local MT for the relayer to be in sync, wouldn't this prevent that if the leaf index is even? Should this be removed?
There was a problem hiding this comment.
Is this function copied from the VAnchor leaf watcher? If so, are we duplicating code that can otherwise be consolidated?
| @@ -0,0 +1,122 @@ | |||
| use ark_bn254::{Bn254, Fr}; | |||
There was a problem hiding this comment.
Thoughts on moving files like these into a separate crate? Something dedicated to all our proof generation needs?
Summary of changes
masp_leaves_handler,masp_proxy_handlerReference issue to close (if applicable)
Code Checklist