Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic release when pushing to develop branch #502

Closed
wants to merge 26 commits into from

Conversation

Nutomic
Copy link
Contributor

@Nutomic Nutomic commented May 12, 2023

Summary of changes

Reference issue to close (if applicable)


Code Checklist

  • Tested
  • Documented

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
Nutomic and others added 2 commits May 12, 2023 11:26
Co-authored-by: shekohex <dev+github@shadykhalifa.me>
branches:
- develop
# TODO: only for testing
- felix/automatic-release
push:
# Sequence of patterns matched against refs/tags
tags:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that multiple push values are always combined with AND, so the workflow is only excecuted if the push is on branch develop AND it is a tag. So far I havent found a way to make an OR condition, other than executing unconditionally and then checking manually if it should continue or abort.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The if statement could be a job that execute first and the other one depends on it?
But your statement is not true as per docs here: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-workflow-only-when-a-push-to-specific-branches-occurs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also this option, where we it runs if a PR got merged: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-pull_request_target-workflow-when-a-pull-request-merges

Since we can't just push to the develop branch without a PR, this could also be an option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would still run on the PR branch so its probably not what we want. I will try running the workflow always on main and develop branches, then checking manually for tags on main.

Copy link
Collaborator

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change the name nightly every where to be develop? we are not going to makea release really every "night". it is just that every time we merge a PR into the develop branch.

@drewstone drewstone closed this May 18, 2023
@shekohex shekohex deleted the felix/automatic-release branch June 23, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Create a new release from the develop branch
4 participants