Update webb to v0.7.3 #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewstone
reviewed
Jul 14, 2023
|
Finally, it is now done, and all tests passes locally (hopefully on CI too). Also Transfer Ownership now works, the test however needs to run either separately with short sessions or manually locally, since the configured tangle session is 20min long, which is not suitable for the CI for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
TODO: Update tests (Needs Update Tangle types to v0.3.2 tangle#213)Reference issue to close (if applicable)
Closes [TASK] Update to latest Solidity and Tangle bindings #561
Blocked by [BUG] DKG Rotates without emittingPublicKeySignatureChangedevent dkg-substrate#685Needs Update to Tangle runtime v0.3.3 webb-rs#147Code Checklist