Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Insertion Event instead of NewCommitment #565

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Use Insertion Event instead of NewCommitment #565

merged 2 commits into from
Jul 24, 2023

Conversation

shekohex
Copy link
Collaborator

Summary of changes

  • Start using Insertion event for handling new commitment for the leaves watchers.
  • Update the logic for saving the merkle-tree validation.

Reference issue to close (if applicable)

Code Checklist

  • Tested
  • Documented

@shekohex shekohex requested a review from drewstone July 24, 2023 15:35
drewstone
drewstone approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drewstone drewstone merged commit a93d134 into develop Jul 24, 2023
8 checks passed
@drewstone drewstone deleted the shady/use-insertion-events branch July 24, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewstone drewstone drewstone approved these changes

@salman01zp salman01zp Awaiting requested review from salman01zp salman01zp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Generalize EVM Event Watchers over MerkleSystems instead of VAnchors
2 participants
@shekohex @drewstone