Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update range proof dependency and curve library #218

Merged
merged 1 commit into from
May 8, 2024

Conversation

AaronFeickert
Copy link
Contributor

@AaronFeickert AaronFeickert commented Jan 15, 2024

Updates the Bulletproofs+ range proof dependency and curve library. Makes a few updates to account for its API changes. Fixes a few lints.

@AaronFeickert
Copy link
Contributor Author

AaronFeickert commented Jan 15, 2024

Looks like something changed with nightly Clippy since the last merge that thinks there's recursion in the key methods. Unsure if the best approach is an allow, or a switch to stable or older nightly Clippy. (For now, I've switched to stable in order to check for any other obvious CI failures.)

Would appreciate suggestions (ping @sdbondi @hansieodendaal @stringhandler).

@hansieodendaal
Copy link
Contributor

I think this change to stable clippy is good

@AaronFeickert
Copy link
Contributor Author

I think this change to stable clippy is good

This is addressed directly in #221.

@AaronFeickert AaronFeickert changed the title chore: update range proof dependency chore: update range proof dependency and curve library May 7, 2024
@AaronFeickert AaronFeickert marked this pull request as ready for review May 7, 2024 16:02
@SWvheerden SWvheerden merged commit dc18c4c into tari-project:main May 8, 2024
7 checks passed
@AaronFeickert AaronFeickert deleted the range-proof-update branch May 8, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants