Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pub constructor to DHKE #230

Merged
merged 4 commits into from
Jun 28, 2024
Merged

feat: add pub constructor to DHKE #230

merged 4 commits into from
Jun 28, 2024

Conversation

SWvheerden
Copy link
Contributor

add pub constructor to DHKE

@ghpbot-tari-project ghpbot-tari-project added the CR-insufficient_context The PR body does not provide enough information to fully describe the changes requested. label Jun 28, 2024
brianp
brianp approved these changes Jun 28, 2024
View reviewed changes
Copy link

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant to say an actual constructor might be preferred, to still prevent direct access to the key. I think it's purpose is to try and prevent it leaking into memory where it's not zeroized
but i'm also okay with this for speed of release

brianp
brianp approved these changes Jun 28, 2024
View reviewed changes
Copy link

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes much more. Retains leak prevention of the inner secret, and allows us to create from an already known secret 👍🏻

@SWvheerden SWvheerden merged commit 494bb73 into tari-project:main Jun 28, 2024
4 checks passed
@SWvheerden SWvheerden deleted the sw_add_pub_constructor branch June 28, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianp brianp brianp approved these changes

Assignees
No one assigned
Labels
CR-insufficient_context The PR body does not provide enough information to fully describe the changes requested.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWvheerden @brianp @ghpbot-tari-project