fix(updater): run cleanup before exit on Windows

[Legend-Master]

Fix #1014

[Legend-Master]

The downside about this is that we will have to assume ShellExecute will run successfully, since we need to clean up before the installer gets executed (installer will kill all running instances)

[Legend-Master]

And, I'm not familiar with how updaters shutdown the app on other platforms, is this just a Windows problem or we need to do something for other platforms as well?

[amrbashir]

And, I'm not familiar with how updaters shutdown the app on other platforms, is this just a Windows problem or we need to do something for other platforms as well?

correct, other platforms update without restarting and wait for users to relaunch.

[amrbashir]

I don't quite like the additional argument, I think a better way to handle this would be to take a generic callback to be executed on before restart, here is some psuedo-code of what I mean:

let builder = UpdaterBuilder::new()
  .with_before_exit(|| {
    app.cleanup_before_exist();
  })
  .build();

and we can provide this callback automatically in the UpdaterExt trait implementation.

[Legend-Master]

A bit off topic for this PR, do we want to expose download and install directly, so that the app can download the update in background and prompt the user once it's done (like the way vscode did it)?

[amrbashir]

they are exposed https://docs.rs/tauri-plugin-updater/latest/tauri_plugin_updater/struct.Update.html#method.download

[Legend-Master]

I think a better way to handle this would be to take a generic callback to be executed on before restart

I'll take a look

they are exposed https://docs.rs/tauri-plugin-updater/latest/tauri_plugin_updater/struct.Update.html#method.download

I mean the JavaScript side

[amrbashir]

I mean the JavaScript side

yeah sure, was hoping to do it at some point

[amrbashir]

Thank you