Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): replace Mutex with RwLock to enable concurrent SQL execution #1972

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

cijiugechu
Copy link
Contributor

When using a Mutex, the MutexGuard will be held until the SQL execution is complete before it is dropped, which is unnecessary and prevents the concurrency capability of the SQL.

Resolves #1935 .

@cijiugechu cijiugechu requested a review from a team as a code owner October 25, 2024 03:07
Copy link
Contributor

github-actions bot commented Oct 25, 2024

Package Changes Through 7bd466d

There are 2 changes which include sql with patch, fs-js with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example-js 2.0.1 2.0.2
fs-js 2.0.1 2.0.2
sql 2.0.1 2.0.2

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member

@FabianLars FabianLars merged commit 4341d7f into tauri-apps:v2 Oct 26, 2024
15 checks passed
@rap2hpoutre
Copy link

Wow thank you for this fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sql] select queries are blocked and not executed concurrently (sqlite)
3 participants