-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add deep link plugin for mobile #504
Conversation
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
I see we're duplicating the config for build vs runtime. We can reuse the same config in an ugly way using |
yeah, i saw that in some Stackoverflow answer but wasn't sure if we're comfortable with that. Or well, could be worse i guess, so why not |
still missing a better explanation on how to get the fingerprint
Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
marked as ready for review so we can get it merged & released asap as discussed on discord. There are still a few things we/i should/want to look into but this PR is already large enough 👍 |
Related to #536 (comment), I've opened an issue in tauri-apps/governance-and-guidance#42 to discuss this further, pending a non-CrabNebula board member to weigh in on this. CC @Beanow |
This is not meant to be merged! It's only to discuss the changes presented here, changes that are still TODO / need to be discussed, and to track what changes are required outside of the plugin (in tauri's bundler f.e.)nvm i guessThe biggest open question is how to handle the required Manifest change. I think ideally there'd be a way to reference the consuming app inside the plugin for example via a handlebar thingy that the cli replaces if that's possible. If it isn't then i think that leaves us with 2 options:
The user has to modify the manifest in their gen folder
the cli modifies that same manifest (or some other one?) at build time, or creates a new one somewhere and merge it into it
is basically like 0) with less plugin-specific which may help for other plugins in the future
-> after a small convo with lucas this sounds pretty difficult
todo list (don't have to be resolved, but talked about at least):
window.__TAURI_INVOKE__
usage withlisten
in the next alpha release (marked asTODO
in the code)TODO
in the code)TODO
s i forgot in there - waiting for Lucas' changes to not cause any conflicts.