Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(websocket): config #541

Merged
merged 6 commits into from
Aug 8, 2023
Merged

fix(websocket): config #541

merged 6 commits into from
Aug 8, 2023

Conversation

Dreaming-Codes
Copy link
Contributor

@Dreaming-Codes Dreaming-Codes commented Aug 7, 2023

In the current version of the tauri-websocket plugin, configurations are being ignored due to the disparity in naming between JavaScript's guest-js and Rust implementation. This Pull Request resolves the issue by aligning the name inside guest-js to 'config', ensuring the configurations function as intended.

@Dreaming-Codes Dreaming-Codes requested a review from a team as a code owner August 7, 2023 21:36
@Dreaming-Codes Dreaming-Codes changed the title fix(websocket): fix config fix(websocket): config Aug 7, 2023
@lucasfernog lucasfernog changed the base branch from v2 to v1 August 8, 2023 12:49
@lucasfernog lucasfernog merged commit ac495b9 into tauri-apps:v1 Aug 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants