-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(http): remove cmd
property from http|fetch
invoke, closes #587
#588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
previously approved these changes
Sep 2, 2023
@i-c-b Thanks for the contribution, could you add a change file as well? |
There is also another bug with the ArrayBuffer, here is the patch file I made to fix the issue temporarily: diff --git a/dist-js/index.min.js b/dist-js/index.min.js
index a61a5cfca422aad611349e6924fa948b8e0cc603..1d08fdc1b40f69fc598a39cea0f94c285eefdf31 100644
--- a/dist-js/index.min.js
+++ b/dist-js/index.min.js
@@ -27,7 +27,6 @@ async function fetch(input, init) {
const buffer = await req.arrayBuffer();
const reqData = buffer.byteLength ? Array.from(new Uint8Array(buffer)) : null;
const rid = await window.__TAURI_INVOKE__("plugin:http|fetch", {
- cmd: "fetch",
method: req.method,
url: req.url,
headers: Array.from(req.headers.entries()),
@@ -46,7 +45,7 @@ async function fetch(input, init) {
const body = await window.__TAURI_INVOKE__("plugin:http|fetch_read_body", {
rid,
});
- const res = new Response(Uint8Array.from(body), {
+ const res = new Response(new Uint8Array(body), {
headers,
status,
statusText,
diff --git a/dist-js/index.mjs b/dist-js/index.mjs
index c7768ebc0abecf32eda4c9e759c7ac40400e00b7..ce9e9b3ab8ac59c5ff3746f8406a002d6d6e94a6 100644
--- a/dist-js/index.mjs
+++ b/dist-js/index.mjs
@@ -27,7 +27,6 @@ async function fetch(input, init) {
const buffer = await req.arrayBuffer();
const reqData = buffer.byteLength ? Array.from(new Uint8Array(buffer)) : null;
const rid = await window.__TAURI_INVOKE__("plugin:http|fetch", {
- cmd: "fetch",
method: req.method,
url: req.url,
headers: Array.from(req.headers.entries()),
@@ -46,7 +45,7 @@ async function fetch(input, init) {
const body = await window.__TAURI_INVOKE__("plugin:http|fetch_read_body", {
rid,
});
- const res = new Response(Uint8Array.from(body), {
+ const res = new Response(new Uint8Array(body), {
headers,
status,
statusText, the line below, need to be changed from
|
Co-authored-by: Louis Bailleau <Bricklou@users.noreply.github.com>
Co-authored-by: Louis Bailleau <Bricklou@users.noreply.github.com>
amrbashir
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #587