Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(updater): Fix endpoint string replacements, fixes #655 #662

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

FabianLars
Copy link
Member

i know it's ugly and i'm open for discussion.
One thing i really wanted to avoid though was decoding the url just for the replacement, to be 100% sure not to mess up whatever url the user provided.
So the only 2 solutions i could think of were this, or reverting it to a simple String again but i wanted to keep the Url validation in the Deserialization impl but that would have made error handling ugly at first glance.

Maybe i'm just too tired and overthinking this while missing the obvious...

@FabianLars FabianLars requested a review from a team as a code owner October 16, 2023 16:59
amrbashir
amrbashir previously approved these changes Oct 16, 2023
@FabianLars
Copy link
Member Author

for commits like this i really hate the auto dismissal...

@amrbashir amrbashir merged commit 28ec084 into v2 Oct 16, 2023
15 checks passed
@amrbashir amrbashir deleted the updater-url branch October 16, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants