fix(updater): Fix endpoint string replacements, fixes #655 #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
previously approved these changes
Oct 16, 2023
|
for commits like this i really hate the auto dismissal... |
amrbashir
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i know it's ugly and i'm open for discussion.
One thing i really wanted to avoid though was decoding the url just for the replacement, to be 100% sure not to mess up whatever url the user provided.
So the only 2 solutions i could think of were this, or reverting it to a simple String again but i wanted to keep the Url validation in the Deserialization impl but that would have made error handling ugly at first glance.
Maybe i'm just too tired and overthinking this while missing the obvious...