fix: remove mut self from set_native_icon signature (#7866)

* fix set_native_icon compile error * Update core/tauri/src/menu/icon.rs * Update core/tauri/src/menu/icon.rs * Create set_native_icon_signature.md * Update .changes/set_native_icon_signature.md
tauri-apps · Sep 20, 2023 · a2021c3 · a2021c3
1 parent d6fd121
commit a2021c3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changes/set_native_icon_signature.md b/.changes/set_native_icon_signature.md
@@ -0,0 +1,5 @@
+---
+"tauri": 'patch:bug'
+---
+
+Changed `IconMenuItem::set_native_icon` signature to take `&self` instead of `&mut self` to fix compilation error on macos.
diff --git a/core/tauri/src/menu/icon.rs b/core/tauri/src/menu/icon.rs
@@ -205,7 +205,7 @@ impl<R: Runtime> IconMenuItem<R> {
   /// ## Platform-specific:
   ///
   /// - **Windows / Linux**: Unsupported.
-  pub fn set_native_icon(&mut self, _icon: Option<NativeIcon>) -> crate::Result<()> {
+  pub fn set_native_icon(&self, _icon: Option<NativeIcon>) -> crate::Result<()> {
     #[cfg(target_os = "macos")]
     return run_main_thread!(self, |self_: Self| self_
       .inner