feat: add visible_on_all_workspaces, closes #6589 #7437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzykro2
force-pushed
the
visible_on_all_workspaces
branch
from
cd2c474
to
5ccbdc5
Compare
amrbashir
requested changes
Jul 20, 2023
Done. PTAL. |
amrbashir
previously approved these changes
Jul 24, 2023
|
Oh looks like you didn't sign some of your commits and I can't merge the PR unless they are signed. You need to setup commit signing, then you can sign past commit like this for example. |
amrbashir
reviewed
Jul 24, 2023
krzykro2
force-pushed
the
visible_on_all_workspaces
branch
from
333c223
to
db0f148
Compare
|
I might have failed at git 🤦 I managed to successfully sign my old commit by rebasing back onto dev, however your commit seems to be unsigned now? |
krzykro2
force-pushed
the
visible_on_all_workspaces
branch
from
2b16018
to
7067aa2
Compare
amrbashir
requested changes
Jul 25, 2023
amrbashir
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
It's my first PR to Tauri, please be gentle. I basically added
visible_on_all_workspacesto all the places where I foundalways_on_top. Haven't found any tests foralways_on_topso haven't added any for my feature. Tested locally on my Linux and works great (given the Tao implementation I would assume it should work great on Mac also).