-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add visible_on_all_workspaces, closes #6589 #7437
Conversation
cd2c474
to
5ccbdc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contribution, could you run cargo fmt
and add a change file in .changes
?
Done. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Oh looks like you didn't sign some of your commits and I can't merge the PR unless they are signed. You need to setup commit signing, then you can sign past commit like this for example. |
333c223
to
db0f148
Compare
I might have failed at git 🤦 I managed to successfully sign my old commit by rebasing back onto dev, however your commit seems to be unsigned now? |
2b16018
to
7067aa2
Compare
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
It's my first PR to Tauri, please be gentle. I basically added
visible_on_all_workspaces
to all the places where I foundalways_on_top
. Haven't found any tests foralways_on_top
so haven't added any for my feature. Tested locally on my Linux and works great (given the Tao implementation I would assume it should work great on Mac also).