Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to always pass use key through special lines like prboom-plus #411

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devinacker
Copy link
Contributor

prboom-plus has an option to treat all special lines as having ML_PASSUSE set, which is needed for cchest2.wad MAP24 (and possibly other "Boom-compatible-but-not-quite" maps) to be completable. This adds that option, disabled by default.

Also attached a dumb test map as a more obvious/contrived example.
passusetest.zip

@ioan-chera
Copy link
Member

Sorry, but I wouldn't add another comp_ option, we have too many already. Also this invites bad level design, kinda like a slippery slope.

I may look more into this if it can be isolated, though I'm also not much fond of wad hacks either (i.e. like ZDoom or occasionally Eternity, activating hidden compatibility flags based on loaded wad hash). Ultimately, if user only tested this on ZDoom, then it's a ZDoom map without all the features, and player can choose between playing it in ZDoom, or cheating/skipping it as buggy. We already have lots of vanilla wads too which are buggy and need cheating, so this is not new.

@Altazimuth
Copy link
Member

I think this is a fair option to have, printz. Enough maps targeting Boom break thanks to only being tested in ZDoom with its non-default defaults. We may have too many comp_ options but this one feels necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants