Filter out ppxAllowStringReturnType

teamwalnut · May 17, 2024 · 79d140a · 79d140a
1 parent 3aebf83
commit 79d140a
Show file tree

Hide file tree

Showing 10 changed files with 16 additions and 17 deletions.
diff --git a/snapshot_tests/operations/expected/apollo/compile/fragmentWithdifferentReturnType.res.txt b/snapshot_tests/operations/expected/apollo/compile/fragmentWithdifferentReturnType.res.txt
@@ -66,7 +66,7 @@ var Raw$1 = {};
 
 var query$1 = Gql`query MyQuery  {
 lists  {
-...ListFragment  @ppxAllowStringReturnType 
+...ListFragment   
 }
 
 }

diff --git a/snapshot_tests/operations/expected/apollo/generate/fragmentWithdifferentReturnType.res.txt b/snapshot_tests/operations/expected/apollo/generate/fragmentWithdifferentReturnType.res.txt
@@ -136,7 +136,7 @@ function back to the original JSON compatible data ")
     [
       "query MyQuery  {
 lists  {
-...ListFragment  @ppxAllowStringReturnType 
+...ListFragment   
 }
 
 }

diff --git a/snapshot_tests/operations/expected/native/generate/fragmentWithdifferentReturnType.res.txt b/snapshot_tests/operations/expected/native/generate/fragmentWithdifferentReturnType.res.txt
@@ -136,7 +136,7 @@ function back to the original JSON compatible data ")
     [
       "query MyQuery  {
 lists  {
-...ListFragment  @ppxAllowStringReturnType 
+...ListFragment   
 }
 
 }

diff --git a/snapshot_tests/operations/expected/records/compile/fragmentWithdifferentReturnType.res.txt b/snapshot_tests/operations/expected/records/compile/fragmentWithdifferentReturnType.res.txt
@@ -63,7 +63,7 @@ var Raw$1 = {};
 
 var query$1 = Gql`query MyQuery  {
 lists  {
-...ListFragment  @ppxAllowStringReturnType 
+...ListFragment   
 }
 
 }

diff --git a/snapshot_tests/operations/expected/records/generate/fragmentWithdifferentReturnType.res.txt b/snapshot_tests/operations/expected/records/generate/fragmentWithdifferentReturnType.res.txt
@@ -136,7 +136,7 @@ function back to the original JSON compatible data ")
     [
       "query MyQuery  {
 lists  {
-...ListFragment  @ppxAllowStringReturnType 
+...ListFragment   
 }
 
 }

diff --git a/snapshot_tests/operations/expected/template/compile/fragmentWithdifferentReturnType.res.txt b/snapshot_tests/operations/expected/template/compile/fragmentWithdifferentReturnType.res.txt
@@ -67,7 +67,7 @@ var Raw$1 = {};
 
 var query$1 = Gql`query MyQuery  {
 lists  {
-...ListFragment  @ppxAllowStringReturnType 
+...ListFragment   
 }
 
 }

diff --git a/snapshot_tests/operations/expected/template/generate/fragmentWithdifferentReturnType.res.txt b/snapshot_tests/operations/expected/template/generate/fragmentWithdifferentReturnType.res.txt
@@ -136,7 +136,7 @@ function back to the original JSON compatible data ")
     [
       "query MyQuery  {
 lists  {
-...ListFragment  @ppxAllowStringReturnType 
+...ListFragment   
 }
 
 }

diff --git a/snapshot_tests/operations/expected/uncurried/compile/fragmentWithdifferentReturnType.res.txt b/snapshot_tests/operations/expected/uncurried/compile/fragmentWithdifferentReturnType.res.txt
@@ -63,7 +63,7 @@ var Raw$1 = {};
 
 var query$1 = Gql`query MyQuery  {
 lists  {
-...ListFragment  @ppxAllowStringReturnType 
+...ListFragment   
 }
 
 }

diff --git a/...shot_tests/operations/expected/uncurried/generate/fragmentWithdifferentReturnType.res.txt b/...shot_tests/operations/expected/uncurried/generate/fragmentWithdifferentReturnType.res.txt
@@ -136,7 +136,7 @@ function back to the original JSON compatible data ")
     [
       "query MyQuery  {
 lists  {
-...ListFragment  @ppxAllowStringReturnType 
+...ListFragment   
 }
 
 }

diff --git a/src/graphql_compiler/graphql_printer.ml b/src/graphql_compiler/graphql_printer.ml
@@ -53,14 +53,13 @@ let print_directive d =
   | None -> ""
 
 let is_internal_directive d =
-  match d.item.d_name.item with
-  | "bsOmitFutureValue" | "ppxOmitFutureValue" | "bsVariant" | "ppxVariant"
-  | "bsRecord" | "ppxRecord" | "bsObject" | "ppxObject" | "bsDecoder"
-  | "ppxDecoder" | "bsCustom" | "ppxCustom" | "ppxCustomOpt" | "bsAs" | "ppxAs"
-  | "argumentDefinitions" | "arguments" | "bsField" | "ppxField" | "ppxConfig"
-    ->
-    true
-  | _ -> false
+  let name = d.item.d_name.item in
+  if
+    String.starts_with ~prefix:"bs" name
+    || String.starts_with ~prefix:"ppx" name
+  then true
+  else
+    match name with "argumentDefinitions" | "arguments" -> true | _ -> false
 
 let print_directives ds =
   " "