Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle unwraps and expects #12

Merged
merged 5 commits into from
Jul 5, 2024
Merged

handle unwraps and expects #12

merged 5 commits into from
Jul 5, 2024

Conversation

Jayko001
Copy link
Collaborator

@Jayko001 Jayko001 commented Jul 5, 2024

No description provided.

@Jayko001 Jayko001 marked this pull request as ready for review July 5, 2024 15:54
@Jayko001 Jayko001 changed the title remove unwraps and expects handle unwraps and expects Jul 5, 2024
theory
theory approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@theory theory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an excellent improvement. Still would like to see tests though.

src/lib.rs Outdated Show resolved Hide resolved
@Jayko001 @theory
fix typo
294d75f 
Co-authored-by: David E. Wheeler <46604+theory@users.noreply.github.com>
@Jayko001 Jayko001 merged commit 1e66280 into main Jul 5, 2024
2 checks passed
@Jayko001 Jayko001 deleted the cloud-989 branch July 5, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theory theory theory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jayko001 @theory